[ovs-dev] [PATCH] ofproto-dpif: Tighten up megaflow wildcard handling.

Justin Pettit jpettit at nicira.com
Wed Jun 19 17:03:56 UTC 2013

On Jun 19, 2013, at 9:21 AM, Ben Pfaff <blp at nicira.com> wrote:

> Why does ipfix need to un-wildcard fields?

Right.  I was thinking it was more like NetFlow than sFlow.  Since we're sampling, we don't need to match on the fields.

> I don't understand the change in compose_output_action__().  It adds
> the ECN bits to the mask but I don't see anything there that depends
> on those bits.
> In do_xlate_actions(), why do OFPACT_SET_VLAN_VID and
> OFPACT_SET_VLAN_PCP have new dependencies?  They do not read the
> fields that they add to the mask.

In both of these cases, we're updating partial fields with a whole field "set", so I think the old value matters.

As we discussed off-line, I sent v2 of the patch with the IPFIX changes removed.


More information about the dev mailing list