[ovs-dev] [RFC PATCH 2/8] ofpacts_check: Remove unnecessary flow copying.

Ben Pfaff blp at nicira.com
Thu Jun 20 20:36:40 UTC 2013


On Thu, Jun 20, 2013 at 05:26:17PM +0300, Jarno Rajahalme wrote:
> 
> Signed-off-by: Jarno Rajahalme <jarno.rajahalme at nsn.com>

I have mixed feelings here.  On one hand, it is nice to avoid a big
copy in some cases (rare cases really).  But on the other hand I am
not fond of interfaces that temporarily modify data, even if they
change it back later, and the pitfalls of such an approach are more of
a problem as threading comes into the picture (and we are currently in
the midst of threading OVS).

What do you think?



More information about the dev mailing list