[ovs-dev] [PATCH 1/4] odp-util: Introduce odp_flow_key_from_mask().

Justin Pettit jpettit at nicira.com
Thu Jun 20 23:35:46 UTC 2013


On Jun 20, 2013, at 4:33 PM, Ben Pfaff <blp at nicira.com> wrote:

> On Thu, Jun 20, 2013 at 04:32:39PM -0700, Justin Pettit wrote:
>> On Jun 20, 2013, at 3:59 PM, Ben Pfaff <blp at nicira.com> wrote:
>> 
>>> On Thu, Jun 20, 2013 at 03:16:42PM -0700, Justin Pettit wrote:
>>>> Add a new function for converting a mask into a set of
>>>> OVS_KEY_ATTR* attributes.  This will be useful in a future commit.
>>>> 
>>>> Signed-off-by: Justin Pettit <jpettit at nicira.com>
>>> 
>>> "sparse" says:
>>> 
>>>   ../lib/odp-util.c:2427:47: warning: incorrect type in argument 4 (different base types)
>>>   ../lib/odp-util.c:2427:47:    expected restricted odp_port_t [usertype] odp_in_port
>>>   ../lib/odp-util.c:2427:47:    got unsigned int [unsigned] [usertype] odp_in_port
>>>   ../lib/odp-util.c:2424:1: error: symbol 'odp_flow_key_from_flow' redeclared with different type (originally declared at ../lib/odp-util.h:103) - incompatible argument 3 (different base types)
>>>   ../lib/odp-util.c:2439:1: error: symbol 'odp_flow_key_from_mask' redeclared with different type (originally declared at ../lib/odp-util.h:105) - incompatible argument 4 (different base types)
>> 
>> Uh, forgot to update from Alex's patches.  Fixed.
> 
> Can I have the fixed version so I can try it too?

I'll respin the whole series once I get feedback on part 4.

--Justin





More information about the dev mailing list