[ovs-dev] [PATCH 4/4] ofproto-dpif: Use megaflows.

Ben Pfaff blp at nicira.com
Thu Jun 20 23:38:58 UTC 2013


On Thu, Jun 20, 2013 at 03:16:45PM -0700, Justin Pettit wrote:
> The commit configures the masks generated from megaflows and pushes
> them through the dpif layer.
> 
> With this commit and a wildcard supporting OVS kernel module,
> ovs-vswitchd's flow setup rate is very close to that of the Linux
> bridge.
> 
> Signed-off-by: Justin Pettit <jpettit at nicira.com>

"sparse" says:

    ../ofproto/ofproto-dpif.c:5063:42: warning: incorrect type in argument 4 (different base types)
    ../ofproto/ofproto-dpif.c:5063:42:    expected restricted odp_port_t [usertype] odp_in_port
    ../ofproto/ofproto-dpif.c:5063:42:    got unsigned int
    ../ofproto/ofproto-dpif.c:3474:45: warning: incorrect type in argument 4 (different base types)
    ../ofproto/ofproto-dpif.c:3474:45:    expected restricted odp_port_t [usertype] odp_in_port
    ../ofproto/ofproto-dpif.c:3474:45:    got unsigned int

I don't think init_flow_miss_execute_op() needs to initialize op->mask
(though it doesn't hurt).

Thanks,

Ben.



More information about the dev mailing list