[ovs-dev] [PATCH 4/4] ofproto-dpif: Use megaflows.

Justin Pettit jpettit at nicira.com
Thu Jun 20 23:54:42 UTC 2013


On Jun 20, 2013, at 4:38 PM, Ben Pfaff <blp at nicira.com> wrote:

> "sparse" says:
> 
>    ../ofproto/ofproto-dpif.c:5063:42: warning: incorrect type in argument 4 (different base types)
>    ../ofproto/ofproto-dpif.c:5063:42:    expected restricted odp_port_t [usertype] odp_in_port
>    ../ofproto/ofproto-dpif.c:5063:42:    got unsigned int
>    ../ofproto/ofproto-dpif.c:3474:45: warning: incorrect type in argument 4 (different base types)
>    ../ofproto/ofproto-dpif.c:3474:45:    expected restricted odp_port_t [usertype] odp_in_port
>    ../ofproto/ofproto-dpif.c:3474:45:    got unsigned int

More fallout from Alex's port typing.  I fixed the problem in the revised patch 1 of this series.

> I don't think init_flow_miss_execute_op() needs to initialize op->mask
> (though it doesn't hurt).

Yeah, I did it out of an abundance of caution, in case someone uses it later.

--Justin





More information about the dev mailing list