[ovs-dev] [PATCH 2/4] ofproto-dpif: Handle failed flow 'put's.

Ben Pfaff blp at nicira.com
Fri Jun 21 00:04:55 UTC 2013


On Thu, Jun 20, 2013 at 04:51:54PM -0700, Justin Pettit wrote:
> If a flow cannot be installed in the datapath, we should notice
> this and not treat it as installed.  This becomes an issue with
> megaflows, since a batch of unique flows may come in that generate
> a single new datapath megaflow that covers them.  Since userspace
> doesn't know whether the datapath supports megaflows, each unique
> flow will get a separate flow entry (which overlap when masks are
> applied) and all except the first will get rejected by a megaflow-
> supporting datapath as duplicates.
> 
> Signed-off-by: Justin Pettit <jpettit at nicira.com>

The new comment in struct flow_miss_op talks about destroying
subfacets, but actually we just mark them as not installed.

Same for a new comment in handle_miss_upcalls().

Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list