[ovs-dev] [PATCH] [RFC] Add OpenFlow 1.3 protocol support for meters.
blp at nicira.com
Mon Jun 24 22:22:22 UTC 2013
On Mon, Jun 24, 2013 at 09:52:25PM +0000, Rajahalme, Jarno (NSN - FI/Espoo) wrote:
> On Jun 20, 2013, at 23:55 , ext Ben Pfaff wrote:
> > From: Neil Zhu <zhuj at centecnetworks.com>
> > Signed-off-by: Neil Zhu <zhuj at centecnetworks.com>
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > ---
> > This is the first of a series of Open vSwitch features contributed
> > by Centec Networks. Other features will include groups, the
> > "table mod" request, and some queue related features.
> > This feature, like the others, does not include Linux kernel
> > datapath support, because Centec produces ASIC-based implementations.
> > This patch is not completely ready to go, but I am posting it now
> > to get the ball rolling.
> Earlier would have been nice, so I wouldn't have had to start from
> scratch :-)
This was really a bad coincidence. Centec gave me this code a long
time ago, as a big .zip file of a tree that also added a bunch of
other features (see above), but I didn't find time to start figuring
out what was there or even what was the right commit to "diff" against
until last week.
> Please find my comments below. After that I'd like you to read
> through at least the ofp-util.h and ofproto* parts of the patches I
> sent last week, please.
What I really want to do is reconcile the two patch series, so that we
can get the best features from both. Your code is always solid in my
experience, so I'm kind of inclined to just review yours and apply it,
and then go through the Centec code and find its strengths and try to
take advantage of them. One place this is likely to be the case is in
the ofproto_provider interface, because the Centec implementation
actually takes advantage of ASIC hardware, which means that the
provider interface there is known to work for that purpose.
More information about the dev