[ovs-dev] [RFC PATCH 4/8] ofproto: Implement OpenFlow 1.3 meter table.

Rajahalme, Jarno (NSN - FI/Espoo) jarno.rajahalme at nsn.com
Wed Jun 26 21:47:30 UTC 2013


On Jun 25, 2013, at 22:38 , ext Ben Pfaff wrote:
...
> I'm not fond of the structure of the new ofpacts_check_ctx().  At a
> minimum, I think that ofpacts_check() should be a trivial wrapper
> around it (just change ofpacts_check_ctx() to ignore 'ctx' if it's
> NULL).  But the inversion of control from a callback function is
> somewhat awkward to begin with, and it's worse with a whole array of
> them.  Could we instead make the caller do the iteration?  It could
> handle the special cases as it likes and call the ofpact-by-ofpact
> verification function for the other cases.

I did this and I agree it is a lot simpler this way.

> 
> The new ofproto-provider functions lack comments.  I think it might be
> nice if they could just be NULL for providers that don't support them.
> 

Done, will post a new patch shortly.

  Jarno




More information about the dev mailing list