[ovs-dev] [xlate v1 17/18] tunnel: Hide 'struct tnl_port' internally.

Ben Pfaff blp at nicira.com
Wed Jun 26 22:20:57 UTC 2013

On Mon, Jun 24, 2013 at 06:59:31PM -0700, Ethan Jackson wrote:
> This simplifies the tunnel module's interface and prevents us from
> having to sync 'struct tnl_port' once ofproto-dpif and
> ofproto-dpif-xlate are disentangled.
> Signed-off-by: Ethan Jackson <ethan at nicira.com>

With this and the previous patch, it took me a minute to catch on
that, although the tunnel code uses struct ofport_dpif pointers all
over, it never looks inside struct ofport_dpif and so it doesn't
depend on its contents or structure.

I'm not really happy with adding another hash lookup along this path,
but we can deal with that in profiling later.

Acked-by: Ben Pfaff <blp at nicira.com>

More information about the dev mailing list