[ovs-dev] [xlate v1 18/18] ofproto-dpif: Modularize ofproto-dpif-xlate.

Ben Pfaff blp at nicira.com
Wed Jun 26 22:46:02 UTC 2013


On Mon, Jun 24, 2013 at 06:59:32PM -0700, Ethan Jackson wrote:
> This patch modularizes ofproto-dpif-xlate by disentangling it from
> ofproto-dpif.  Instead of poking around in ofproto-dpif's internal
> data structures, ofproto-dpif-xlate is updated with a simple API
> which can easily be made thread safe.  There are still some places
> where ofproto-dpif-xlate needs to call into ofproto-dpif, but this
> patch makes significant progress towards the final goal.
> 
> Signed-off-by: Ethan Jackson <ethan at nicira.com>

Most of this is search and replace.  I tried to read the bits that
weren't pretty carefully.

I used to get occasional race condition related failures on the lacp
test.  With this series, though, I seem to get reliable failures (five
tries, five pairs of failures) of this and another test, like this:

lacp

  3: lacp - negotiation                              FAILED (lacp.at:162)

ofproto-dpif -- megaflows

630: ofproto-dpif megaflow - normal, balance-tcp bonding FAILED (ofproto-dpif.at:2419)


Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list