[ovs-dev] [RFC PATCH 3/8] ofp-util: Support for OpenFlow 1.3 meters.

[Ben Pfaff]

On Wed, Jun 26, 2013 at 10:47:22PM +0000, Rajahalme, Jarno (NSN - FI/Espoo) wrote:
> 
> On Jun 25, 2013, at 20:35 , ext Ben Pfaff wrote:
> 
> > On Thu, Jun 20, 2013 at 05:26:18PM +0300, Jarno Rajahalme wrote:
> >> 
> >> Signed-off-by: Jarno Rajahalme <jarno.rajahalme at nsn.com>
> > 
> > I'm applied this to master.  I'm appending the incremental that I
> > folded in.  Most of the changes are minor improvements (some just
> > stylistic).  The only important change is that it looked to me like
> > the OpenFlow parsing code in ofp-util.c didn't check that the lengths
> > were valid, so I adjusted them so that they did check.
> 
> Thanks for doing the fixes rather than bouncing them back at me :-)

Sometimes I feel inspired, sometimes I don't ;-)

> > I noticed that the tests seem to use impossible numbers of nanoseconds
> > (greater than 1e9), but I didn't change that other than the
> > formatting.
> 
> Oops, I just put some random numbers there. Will fix in a later patch.

Thanks.