[ovs-dev] [PATCH] ovs-dpctl: Fix mega flow output

Ben Pfaff blp at nicira.com
Fri Jun 28 05:16:53 UTC 2013


On Wed, Jun 26, 2013 at 01:10:03AM -0700, Andy Zhou wrote:
> ovs-dpctl sometimes displays wildcarded fields as exact match. This
> patch fixes those cases.
> 
> This patch implements the following logic. When OVS_FLOW_ATTR_MASK is
> missing, the entire key attributes will be displayed as exact match fields.
> When OVS_FLOW_ATTR_MASK is present, but some individual key attributes do
> not have matching attributes in the mask, those key attributes will be
> displayed as wildcarded fields.
> 
> Signed-off-by: Andy Zhou <azhou at nicira.com>

The cast at the end of generate_all_wildcard_mask() should not be
necessary, because void * implicitly converts to any pointer to object
or incomplete type.

This change looks odd.  I think 0 was fine:
> -    memset(&nd_key, 0, sizeof nd_key);
> +    memset(&nd_key, 0x0, sizeof nd_key);

I am a little surprised that no test cases need to change.  That
indicates that we might need more test cases.

Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list