[ovs-dev] [PATCH] ovs-dpctl: Fix mega flow output

Justin Pettit jpettit at nicira.com
Fri Jun 28 05:50:38 UTC 2013


Yeah, no problem. Thanks. 

--Justin


On Jun 27, 2013, at 10:43 PM, Ben Pfaff <blp at nicira.com> wrote:

> Justin, I'd appreciate if you'd handle this one.
> 
> On Jun 27, 2013 10:37 PM, "Justin Pettit" <jpettit at nicira.com> wrote:
>> Who wants to make the change?  Ben, unless you want to handle it, Andy, can you respin it as a v2?  If so, then I'll backport it and commit it when I get back home in the next hour. 
>> 
>> --Justin
>> 
>> 
>> On Jun 27, 2013, at 10:32 PM, Andy Zhou <azhou at nicira.com> wrote:
>> 
>>> Ben, thanks for the review. I agree with your comments. 
>>> 
>>> 
>>> On Thu, Jun 27, 2013 at 10:16 PM, Ben Pfaff <blp at nicira.com> wrote:
>>>> On Wed, Jun 26, 2013 at 01:10:03AM -0700, Andy Zhou wrote:
>>>> > ovs-dpctl sometimes displays wildcarded fields as exact match. This
>>>> > patch fixes those cases.
>>>> >
>>>> > This patch implements the following logic. When OVS_FLOW_ATTR_MASK is
>>>> > missing, the entire key attributes will be displayed as exact match fields.
>>>> > When OVS_FLOW_ATTR_MASK is present, but some individual key attributes do
>>>> > not have matching attributes in the mask, those key attributes will be
>>>> > displayed as wildcarded fields.
>>>> >
>>>> > Signed-off-by: Andy Zhou <azhou at nicira.com>
>>>> 
>>>> The cast at the end of generate_all_wildcard_mask() should not be
>>>> necessary, because void * implicitly converts to any pointer to object
>>>> or incomplete type.
>>> Agreed.  
>>>> 
>>>> This change looks odd.  I think 0 was fine:
>>>> > -    memset(&nd_key, 0, sizeof nd_key);
>>>> > +    memset(&nd_key, 0x0, sizeof nd_key);
>>>  
>>>> 
>>>> I am a little surprised that no test cases need to change.  That
>>>> indicates that we might need more test cases. 
>>> Agreed.  
>>>> 
>>>> Acked-by: Ben Pfaff <blp at nicira.com>
>>> 
>>> _______________________________________________
>>> dev mailing list
>>> dev at openvswitch.org
>>> http://openvswitch.org/mailman/listinfo/dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20130627/2b19aed2/attachment-0003.html>


More information about the dev mailing list