[ovs-dev] [threads 03/11] ovs-atomic: New library for atomic operations.

Ben Pfaff blp at nicira.com
Fri Jun 28 22:28:33 UTC 2013


On Fri, Jun 28, 2013 at 03:14:36PM -0700, Ethan Jackson wrote:
> Thanks for writing up something so thorough.  Better to get it done
> now then jerry rig stuff ad hoc as we need it.
> 
> There are a couple of "XXX kill_dependency" comments in the code.
> Could you expand the comment a bit to explain what it's referring to?

Oh, that was a note to try to implement the C11 "kill_dependency()"
function.  I don't think I can, but I don't think it matters.  Mind if
I just delete the comment?

> In ovs-atomic.h is it fair to assume that sparse supports c11
> features?  If not, does it make ense to check if __CHECKER__ before
> checking if HAVE_STDATOMIC?

sparse doesn't support C11.  I'll put the __CHECKER__ case first.  OK?

> Acked-by: Ethan Jackson <ethan at nicira.com>

Thanks for the review.



More information about the dev mailing list