[ovs-dev] [xlate v1 01/18] ofproto-dpif: Handle dest mirrors in compose_output_action().

Ethan Jackson ethan at nicira.com
Fri Jun 28 23:11:28 UTC 2013


> What I expected to see was that each compose_output_action() would add
> the mirrors for that output to a set of mirrors to ultimately use, and
> that somewhere else (just one place) we would add the mirrors for the
> input to this same set, and that at the end we would use the set of
> mirrors to do the mirroring.
>
> What I see here is that each compose_output_action() computes the set
> of input mirrors, adds in the provided set of output mirrors,
> subtracts the mirrors already output to, and then outputs to any
> remaining ones.

Yeah that does make more sense doesn't it . . .  Perhaps the only
issue is that it doesn't work across patch ports, but neither did the
original code.  I'll put some thought into it.

Ethan
X-CudaMail-Whitelist-To: dev at openvswitch.org



More information about the dev mailing list