[ovs-dev] [PATCH 1/2] ovs-ctl.in: Clean up code for the next commit.

Gurucharan Shetty shettyg at nicira.com
Tue Mar 5 17:33:44 UTC 2013


On Tue, Mar 5, 2013 at 9:17 AM, Ben Pfaff <blp at nicira.com> wrote:
> On Thu, Feb 28, 2013 at 03:28:52PM -0800, Gurucharan Shetty wrote:
>> Clean up code and carve out a couple of functions
>> which will be used by the next commit.
>>
>> Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
>
> I think this is OK, but a more specific commit message would be welcome.

How about the following commit message?

ovs-ctl.in: Clean up code for the next commit.

Previously, we would null the variables holding the names of the restore
scripts in case there were any errors in creating the restore script or if
we did not need to run a particular restore script. That is not necessary,
as we can just check the execution permission set on those scirpts.

Also, carve out a couple of functions which will be used in the next commit.

Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>



More information about the dev mailing list