[ovs-dev] [PATCH 3/4] tunnel: Generate datapath flows for tunneled packets dropped due to ECN.

Justin Pettit jpettit at nicira.com
Tue Mar 5 06:55:42 UTC 2013


On Feb 14, 2013, at 12:12 PM, Ben Pfaff <blp at nicira.com> wrote:

> I think we can put the test that this patch adds to do_xlate_actions()
> in xlate_actions() instead, adding it as another clause (probably via
> helper function?) in the same 'if' statement as the may_receive() test.
> That's preferable because we'd only do it one time per translation
> instead of once per resubmit.

Good point.  Done.

> The outer () is not needed here:
>> +        && ((ctx->base_flow.tunnel.ip_tos & IP_ECN_MASK) == IP_ECN_CE)

Yeah, that's just how the original code was written, but I changed it.

--Justin





More information about the dev mailing list