[ovs-dev] [RFC PATCH 1/2] add igmp snooping support

Cong Wang amwang at redhat.com
Wed Mar 6 14:57:46 UTC 2013


On Tue, 2013-03-05 at 09:34 -0800, Ben Pfaff wrote:
> On Fri, Mar 01, 2013 at 09:03:44PM +0800, Cong Wang wrote:
> > WARNING: This patch *only* compiles! NOT tested yet!
> > 
> > This patch adds the initial IGMP snooping support.
> > I sent out this patch early to get some early reviews,
> > especially the design of the code.
> > 
> > Any comments are welcome!
> > 
> > Cc: Ben Pfaff <blp at nicira.com>
> > Cc: Jesse Gross <jesse at nicira.com>
> > Not-Yet-Signed-off-by: Cong Wang <amwang at redhat.com>
> 
> Hi Cong.  IGMP snooping is a nice feature to have.  The code looks OK at
> first skim.

Great, thanks for your positive feedback!

> 
> One thing we've been trying to do as we introduce new features is to
> try to make them useful apart from the "normal" action where we can.  Do
> you have an idea how that can be done for IGMP snooping?

Not yet, currently I have no idea on how to integrate it with openflow
tables.

> 
> I'd prefer to avoid adding a new struct flow member for this case.  I
> hope we can reuse an existing member.
> 

Yeah, makes sense, I will dig which members can be reused.

Thanks!




More information about the dev mailing list