[ovs-dev] [PATCH] ofproto-dpif: Print slow-path actions instead of "drop" in dump-flows.

Ben Pfaff blp at nicira.com
Thu Mar 7 19:11:16 UTC 2013


On Wed, Mar 06, 2013 at 05:16:24PM -0800, Justin Pettit wrote:
> The command "ovs-appctl dpif/dump-flows" would print slow-path actions
> as "drop", which could be confusing to users.  This is different from
> "ovs-dpctl dump-flows", which prints a descriptive reason.  This commit
> replaces "drop" with the reason.
> 
> Bug #14840
> 
> Signed-off-by: Justin Pettit <jpettit at nicira.com>

Looks good.

But here I'd expect the arguments on the second and third line to be
indented just past the opening parenthesis:
> +            compose_slow_path(ofproto, &subfacet->facet->flow, subfacet->slow,
> +                    slow_path_stub, sizeof slow_path_stub,
> +                    &actions, &actions_len);


Thanks,

Ben.



More information about the dev mailing list