[ovs-dev] [PATCH v2] rhel: Prevent duplicate ifup calls.

[Ben Pfaff]

On Thu, Mar 14, 2013 at 10:25:39AM -0700, Gurucharan Shetty wrote:
> >
> > I don't understand the logic.  Why, if OVSBRIDGECONFIGURED=yes, do we
> > run the script if DHCP is enabled but not with a static configuration?
> > (This might be a good topic for a comment in the script.)
> 
> It is a little dirty. When dhcp is enabled, the assumption is that
> there will be a port to attach (otherwise, we can't reach out for
> dhcp). So, when dhcp is enabled, we don't configure the bridge through
> rhel ifup infrastructure. We only do that after the port for that
> bridge is configured (through OVSINTF=${DEVICE} /sbin/ifup
> "$OVS_BRIDGE").
> 
> When dhcp is not enabled, I guess the assumption was that someone may
> want a standalone bridge without any port attached to it. So we
> continue and configure the bridge. Does that explain?

This makes sense.  It might be worth adding a comment.

The code looks good.  If you think that Denis is likely to be able to
test it, then maybe it is worth waiting a little while for that.
Otherwise, I'm happy with it.

Thanks,

Ben.