[ovs-dev] [PATCH 2/4] Remove encal_dl_type from struct flow

Jesse Gross jesse at nicira.com
Fri Mar 15 22:07:33 UTC 2013


On Fri, Mar 15, 2013 at 7:27 AM, Simon Horman <horms at verge.net.au> wrote:
> There were plans to use this in conjunction with inner/outer flows,
> however that plan has been changed in favour of using recirculation.
> This leaves us with the current usage.
>
> encal_dl_type is currently only used to allow decoding of packets used in
> the test suite. However, this is a bit of a fudge and the packets may be
> provided as hexadecimal instead.
>
> Also remove comments from parse_l2_5_onward() relating to MPLS which are
> not in keeping with the commenting throughout the rest of the function.
>
> Signed-off-by: Simon Horman <horms at verge.net.au>

Also applied.

Can we also remove mpls_depth?  It doesn't seem very safe to me
because it is extracted in userspace but the kernel flow could vary.



More information about the dev mailing list