[ovs-dev] [PATCH 3/3] rhel: Remove timeouts from ifup and ifdown scripts.

Gurucharan Shetty shettyg at nicira.com
Mon Mar 18 19:39:33 UTC 2013


On Mon, Mar 18, 2013 at 12:18 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Mon, Mar 18, 2013 at 10:48:49AM -0700, Gurucharan Shetty wrote:
>> Previously, ovs-vsctl would wait for ever if ovsdb-server
>> was not running. In such a situation, it made sense to use
>> a "--timeout" value to prevent a stuck startup script. But now,
>> ovs-vsctl by default returns an error if ovsdb-server is
>> not running. So, we no longer need the timeout option.
>>
>> Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
>
> After looking these changes over, I see that all of them remove
> timeouts from ovs-vsctl commands that modify the database   That means
> that, if we remove the timeouts now, there is a risk that if
> ovsdb-server is running but ovs-vswitchd is not, then the command will
> still hang "forever".  I think that we can solve that problem too but
> until we do, I don't think it's wise to remove the timeouts here.

Okay. I did not realize that. I will abandon this. I saw that you
removed timeout in debian/ifupdown.sh.
It probably makes sense to re-add it. I can send a patch for that.


>
> Thanks,
>
> Ben.



More information about the dev mailing list