[ovs-dev] [PATCH -next] openvswitch: fix error return code in ovs_vport_cmd_set()

Jesse Gross jesse at nicira.com
Wed Mar 20 15:57:53 UTC 2013


On Wed, Mar 20, 2013 at 5:14 AM, Wei Yongjun <weiyj.lk at gmail.com> wrote:
> From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as returned elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn>

This isn't right because at this point in the function the change has
already been made, only the notification allocation failed.  Therefore
we don't want to return an error since the caller will assume that
nothing has changed; instead an error is set on the Netlink socket.



More information about the dev mailing list