[ovs-dev] [PATCH] automake: ofp-errors.inc is generated inside srcdir

[Ben Pfaff]

On Fri, Mar 22, 2013 at 04:46:52PM +0100, Damien Millescamps wrote:
> On 03/21/2013 08:44 PM, Ben Pfaff wrote:
> > On Thu, Mar 21, 2013 at 10:52:37AM +0100, Damien Millescamps wrote:
> >> On 03/20/2013 10:20 PM, Ben Pfaff wrote:
> > The straightforward solution is to use a writable source directory.
> > Since you are not using the straightforward solution, you have to use
> > some other solution.
> >
> 
> I don't get why it is not straight forward to not make rule that write
> to the source directory.
> This is actually a best practice when using autoconf to never declare
> any rule that would write in the source directory.

This is about Automake, not Autoconf.

Rules that update the source directory are appropriate to update files
that are distributed.  If you disagree, then feel free to report a bug
to the Automake maintainers that, if you update "configure.ac" or
"Makefile.am" or a Texinfo file, then "configure" and "Makefile.in" and
the Info files get updated in the source directory.

> >> From my understanding, my patch could be part of the solution. There
> >> could be an additional check on the presence of python during the
> >> configure step, and lib/ofp-errors.inc could be removed from the make dist.
> >> Is this what you mean ?
> > No.  That would make everything more complicated.  It would also make
> > the contents of the distribution tarball unpredictable: its contents
> > would depend on what software was installed on the computer that runs
> > "make dist", whereas it does not currently depend on that.
> >
> > I am suggesting that we require the machine on which Open vSwitch is
> > built to have Python installed.  Then we can always generate
> > ofp-errors.inc at build time, so there is no need to distribute it.
> That's what I said, or at least try to say...

OK.  I'd take a patch to do that.  I'd need to go verify that the
XenServer DDK really has Python, but I'm reasonably sure.

Thanks,

Ben.