[ovs-dev] [PATCH] lacp.at: Change timing of lacp - negotiation test

Jarno Rajahalme jarno.rajahalme at nsn.com
Thu Mar 28 13:47:46 UTC 2013


The "lacp - negotiation" test (# 3) used to always fail when running
multiple tests in parallel (-j2).  The reduced simulated wait time
(from 4 seconds to 2.5 seconds) seems to still give the expected result,
and works also when running multiple tests in parallel.

---
Tested with upto -j4, x2 the cores in the test laptop.
Maybe someone with a really fast machine needs to check that this
test still works.

Signed-off-by: Jarno Rajahalme <jarno.rajahalme at nsn.com>
---
 tests/lacp.at |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/lacp.at b/tests/lacp.at
index 49f3bb1..85447c9 100644
--- a/tests/lacp.at
+++ b/tests/lacp.at
@@ -290,13 +290,13 @@ AT_CHECK([grep 'active slave' stdout], [0], [dnl
 ])
 
 # Redirect the patch link between p0 and p2 so that no packets get
-# back and forth across them anymore.  Then wait 4 simulated
+# back and forth across them anymore.  Then wait 2.5 simulated
 # seconds.  The LACP state should become "expired" for p0 and p2.
 AT_CHECK([ovs-vsctl \
 -- add-port br0 null0 -- set int null0 type=patch options:peer=p2 -- set int p2 options:peer=null0 \
 -- add-port br1 null1 -- set int null1 type=patch options:peer=p0 -- set int p0 options:peer=null1])
 
-for i in `seq 0 40`; do ovs-appctl time/warp 100; done
+for i in `seq 0 25`; do ovs-appctl time/warp 100; done
 AT_CHECK(
   [ovs-appctl lacp/show bond0
 ovs-appctl lacp/show bond1
-- 
1.7.10.4




More information about the dev mailing list