[ovs-dev] [PATCH] Always update ethertype on mpls_pop

Ben Pfaff blp at nicira.com
Wed May 1 23:28:45 UTC 2013


On Thu, May 02, 2013 at 08:27:48AM +0900, Simon Horman wrote:
> On Wed, May 01, 2013 at 03:53:37PM -0700, Ben Pfaff wrote:
> > On Thu, May 02, 2013 at 07:40:53AM +0900, Simon Horman wrote:
> > > On Wed, May 01, 2013 at 09:54:03AM -0700, Ben Pfaff wrote:
> > > > On Wed, May 01, 2013 at 05:06:02PM +0900, Simon Horman wrote:
> > > > > The ethertype should always be updated on mpls_pop
> > > > > as there may be a transition between MPLS unicast (0x8847) and
> > > > > MPLS multicast (0x8848).
> > > > > 
> > > > > Signed-off-by: Simon Horman <horms+renesas at verge.net.au>
> > > > 
> > > > The comment on pop_mpls() needs an update.
> > > > 
> > > > EXT-194 in the OpenFlow extensibility JIRA bug tracker says that this
> > > > is the correct behavior.  Will you cite that in a comment and the
> > > > commit log?
> > > 
> > > Sure, can you let me know where I can view EXT-194.
> > 
> > https://rs.opennetworking.org/bugs/browse/EXT-194 but you have to have
> > an account to view it.
> 
> I have added an account but I seem to get a permission violation
> when accessing the URL above. Perhaps I need to be added to a group?
> Or wait a bit?

I don't know.  I'd start by waiting a bit.



More information about the dev mailing list