[ovs-dev] [const 0/9] Mark many static data structures as const.

Andy Zhou azhou at nicira.com
Fri May 3 20:13:09 UTC 2013


I have reviewed all 9 patches. They look fine. Thanks.


On Wed, May 1, 2013 at 11:20 AM, Ben Pfaff <blp at nicira.com> wrote:

> In preparation for multithreading OVS, it makes sense to mark any
> static data that we can "const", because read-only access to data
> is obviously thread-safe.
>
> Ben Pfaff (9):
>   dpif-linux: Make dummy_action const in dpif_linux_init_flow_put().
>   Make most "struct option" instances "const".
>   hmap: Make HMAP_INITIALIZER a valid initializer for a const hmap.
>   netdev-linux: Mark more static data as "const".
>   netdev: Make 'smap' variable const in netdev_set_qos().
>   stream-fd: Mark 'fd_pstream_class' const.
>   vlog: Mark more static data const.
>   ofp-util: Make names[] in ofputil_action_code_from_name() const-ier.
>   vconn: Mark class structures as const.
>
>  lib/dpif-linux.c           |    6 ++++--
>  lib/hmap.h                 |    3 ++-
>  lib/netdev-linux.c         |   30 ++++++++++++++----------------
>  lib/netdev.c               |    2 +-
>  lib/ofp-util.c             |    4 ++--
>  lib/stream-fd.c            |    4 ++--
>  lib/vconn-provider.h       |   20 ++++++++++----------
>  lib/vconn-stream.c         |   20 ++++++++++----------
>  lib/vconn.c                |   30 +++++++++++++++---------------
>  lib/vlog.c                 |    6 +++---
>  ovsdb/ovsdb-client.c       |    4 ++--
>  ovsdb/ovsdb-server.c       |    2 +-
>  ovsdb/ovsdb-tool.c         |    2 +-
>  tests/test-jsonrpc.c       |    4 ++--
>  tests/test-netflow.c       |    2 +-
>  tests/test-ovsdb.c         |    2 +-
>  tests/test-sflow.c         |    2 +-
>  tests/test-util.c          |    2 +-
>  utilities/ovs-benchmark.c  |    4 ++--
>  utilities/ovs-controller.c |    2 +-
>  utilities/ovs-dpctl.c      |    2 +-
>  utilities/ovs-ofctl.c      |    2 +-
>  vswitchd/ovs-vswitchd.c    |    2 +-
>  23 files changed, 79 insertions(+), 78 deletions(-)
>
> --
> 1.7.2.5
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20130503/bfc34932/attachment-0003.html>


More information about the dev mailing list