[ovs-dev] [monitor 3/3] ovs-ofctl: Make "ovs-ofctl monitor" respond to echo requests.

Ben Pfaff blp at nicira.com
Fri May 3 20:59:30 UTC 2013


Thanks.  I made that change, and removed "&& retval != EAGAIN" from
the "if" condition (since vconn_send_block() does not return EAGAIN),
and applied this series to master.

On Fri, May 03, 2013 at 01:49:03PM -0700, Ethan Jackson wrote:
> Fine with me.
> 
> Acked-by: Ethan Jackson <ethan at nicira.com>
> 
> On Fri, May 3, 2013 at 1:45 PM, Ben Pfaff <blp at nicira.com> wrote:
> > On Fri, May 03, 2013 at 01:36:28PM -0700, Ethan Jackson wrote:
> >> > +            case OFPTYPE_ECHO_REQUEST:
> >> > +                if (reply_to_echo_requests) {
> >> > +                    struct ofpbuf *reply;
> >> > +
> >> > +                    reply = make_echo_reply(b->data);
> >> > +                    retval = vconn_send(vconn, reply);
> >> > +                    if (retval && retval != EAGAIN) {
> >> > +                        ovs_fatal(retval, "failed to send echo reply");
> >> > +                    }
> >> > +                }
> >>
> >> I think we need to destroy 'reply' when vconn_send() returns EAGAIN.
> >> Otherwise I think we leak it.
> >
> > How about if I change "vconn_send()" to "vconn_send_block()" here?
> >
> > Thanks,
> >
> > Ben.



More information about the dev mailing list