[ovs-dev] [PATCH 1/4] ofproto-dpif.c: Re-implement the ofproto/trace command

Ben Pfaff blp at nicira.com
Mon May 6 22:45:45 UTC 2013


On Mon, May 06, 2013 at 10:11:14AM -0700, Alex Wang <alexw at nicira.com > wrote:
> From: Alex Wang <alexw at nicira.com>
> 
> Since the use of single datapath, all bridges belonging to the same type of
> datapath will use the same (single) datapath. This causes confusion in the
> current 'ofproto/trace' command. Especially, when given the unrelated
> 'bridge' and 'in_port' combination, the current implementation will still
> be able to process and give misleading output. Thusly, this patch changes
> the 'ofproto/trace' command syntax to formats shown as follow.
> 
> ofproto/trace [datapath] priority tun_id in_port mark packet
> ofproto/trace [datapath] dp_flow [-generate]
> ofproto/trace bridge br_flow [-generate]
> 
> Therein, the bridge name is replaced by datapath name in the first format,
> since the mapping between in_port and the corresponding datapath is unique.
> The second format requires datapath name since it uses 'ovs-dpctl dump-flows'
> output. And the thrid format requires bridge name since it uses 'ovs-ofctl
> add-flow' input like flow.
> 
> Signed-off-by: Alex Wang <alexw at nicira.com>

Hi Alex.  Before I start reviewing the patches themselves, it looks to
me like patch 1 breaks the tests, then patch 2 fixes them, then patch
4 updates the documentation to match the change from patch 1.  If I'm
understanding that correctly, then patches 1, 2, and 4 should all be a
single patch: we don't want test failures after any single patch is
applied, and similarly we don't want incorrect or incomplete
documentation after any single patch is applied.



More information about the dev mailing list