[ovs-dev] [PATCH] Use updated dl_type when checking actions that use fields

[Ben Pfaff]

On Thu, May 02, 2013 at 06:06:46PM +0900, Simon Horman wrote:
> Update handling of the following actions to use the dl_type set by MPLS
> push and pop actions if it differs from the original dl_type. This is
> consistent with the existing checking of load actions and allows
> their existing checks to enforce dl_type pre-requisites correctly.
> 
> 	output_reg
> 	bundle
> 	reg_move
> 	stack_push
> 	stack_pop
> 	learn
> 	multipath
> 
> In order to avoid the verbosity of updating the flow for each applicable
> action the update is treated as a common case and performed at the top of
> ofpact_check__().  This was suggested by Jesse Gross.
> 
> Cc: Jesse Gross <jesse at nicira.com>
> Signed-off-by: Simon Horman <horms at verge.net.au>

Jesse, it looks like you suggested this, do you want to review it?

I think that there may be a related issue though: it looks to me like
a pop_mpls action has no effect on dl_type if there is no MPLS header,
but I think that the logic for checking actions assumes that pop_mpls
always updates dl_type.