[ovs-dev] [PATCH] ofproto-dpif: Make fin_timeout work when governor kicks in.

[Ben Pfaff]

Thanks a lot.
On May 13, 2013 11:28 AM, "Ethan Jackson" <ethan at nicira.com> wrote:

> Acked-by: Ethan Jackson <ethan at nicira.com>
>
> I made a slight tweak to the patch.  Specifically I passed the
> tcp_flags into action_xlate_ctx_init() instead of mucking with the
> context directly.  I'll merge this and backport it to the relevant
> branches.
>
> On Sun, May 12, 2013 at 2:53 PM, Ben Pfaff <blp at nicira.com> wrote:
> > The xlate_actions() call in handle_flow_miss_without_facet() didn't
> > implement fin_timeout properly because tcp_flags wasn't getting set.
> >
> > I have not tested that this fixes the problem, but it seems "obviously
> > correct".
> >
> > Bug #16506.
> > Reported-by: Ying Chen <yingchen at vmware.com>
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > ---
> >  AUTHORS                |    1 +
> >  ofproto/ofproto-dpif.c |    1 +
> >  2 files changed, 2 insertions(+)
> >
> > diff --git a/AUTHORS b/AUTHORS
> > index c113f16..498e9f0 100644
> > --- a/AUTHORS
> > +++ b/AUTHORS
> > @@ -206,6 +206,7 @@ Vjekoslav Brajkovic     balkan at cs.washington.edu
> >  Voravit T.              voravit at kth.se
> >  YAMAMOTO Takashi        yamamoto at valinux.co.jp
> >  Yeming Zhao             zhaoyeming at gmail.com
> > +Ying Chen               yingchen at vmware.com
> >  Yongqiang Liu           liuyq7809 at gmail.com
> >  kk yap                  yapkke at stanford.edu
> >  likunyun                kunyunli at hotmail.com
> > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
> > index 1da8ffb..ecb50d5 100644
> > --- a/ofproto/ofproto-dpif.c
> > +++ b/ofproto/ofproto-dpif.c
> > @@ -3689,6 +3689,7 @@ handle_flow_miss_without_facet(struct flow_miss
> *miss,
> >          action_xlate_ctx_init(&ctx, ofproto, &miss->flow,
> >                                &miss->initial_vals, rule, 0, packet);
> >          ctx.resubmit_stats = &stats;
> > +        ctx.tcp_flags = stats.tcp_flags;
> >          xlate_actions(&ctx, rule->up.ofpacts, rule->up.ofpacts_len,
> >                        &odp_actions);
> >
> > --
> > 1.7.10.4
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20130513/d5a0214c/attachment-0004.html>