[ovs-dev] [PATCH 2/2] Do not include trailing whitespace in hexdump.

Simon Horman horms at verge.net.au
Thu May 16 08:43:48 UTC 2013


On Wed, May 15, 2013 at 10:36:07PM -0700, Ben Pfaff wrote:
> Reported-by: Simon Horman <horms at verge.net.au>
> Signed-off-by: Ben Pfaff <blp at nicira.com>

This, and by implication the previous patch too,

Tested-by: Simon Horman <horms at verge.net.au>

> ---
>  lib/dynamic-string.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/lib/dynamic-string.c b/lib/dynamic-string.c
> index b35fd0b..3cccb5c 100644
> --- a/lib/dynamic-string.c
> +++ b/lib/dynamic-string.c
> @@ -394,6 +394,8 @@ ds_put_hex_dump(struct ds *ds, const void *buf_, size_t size,
>              for (; i < per_line; i++)
>                  ds_put_format(ds, " ");
>              ds_put_format(ds, "|");
> +        } else {
> +            ds_chomp(ds, ' ');
>          }
>          ds_put_format(ds, "\n");
>  
> -- 
> 1.7.10.4
> 



More information about the dev mailing list