[ovs-dev] [PATCH] netdev-dummy: Remove FreeBSD dependency.

Ben Pfaff blp at nicira.com
Sat May 18 15:30:44 UTC 2013


On Sat, May 18, 2013 at 12:12:12AM -0400, Ed Maste wrote:
> On 17 May 2013 18:57, Ben Pfaff <blp at nicira.com> wrote:
> > There's no particular reason that netdev_dummy_register() has to care about
> > the particular OS, except that the tests like to use the special Linux-only
> > tunnel vport types.  But that can be done better, I think, by just always
> > registering them from netdev_dummy_register() and making that function
> > idempotent, so that calling it twice under Linux has no additional effect.
> > This commit implements that solution.
> >
> > CC: Ed Maste <emaste at freebsd.org>
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> 
> Acked-by: Ed Maste <emaste at freebsd.org>
> 
> Looks good to me, and unit tests continue to pass on FreeBSD.

Thank you for the review.  I applied this to master.



More information about the dev mailing list