[ovs-dev] [PATCH] lib/dpif-netdev.c: Remove redundant call to flow_extract

Alex Wang alexw at nicira.com
Tue May 21 18:33:58 UTC 2013


This commit removes the redundant call to flow_extract in dpif_netdev_execute,
since in the next line, the call to dpif_netdev_flow_from_nlattrs will reset
the flow variable.

Signed-off-by: Alex Wang <alexw at nicira.com>
---
 lib/dpif-netdev.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 78bdedb..4ad2823 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -941,7 +941,6 @@ dpif_netdev_execute(struct dpif *dpif, const struct dpif_execute *execute)
     ofpbuf_reserve(&copy, DP_NETDEV_HEADROOM);
     ofpbuf_put(&copy, execute->packet->data, execute->packet->size);
 
-    flow_extract(&copy, 0, 0, NULL, -1, &key);
     error = dpif_netdev_flow_from_nlattrs(execute->key, execute->key_len,
                                           &key);
     if (!error) {
-- 
1.7.9.5




More information about the dev mailing list