[ovs-dev] [PATCH next-next v4 1/2] net: Use 16bits for inner_*_headers fields of struct skbuff

Pekka Riikonen priikone at iki.fi
Wed May 22 07:25:16 UTC 2013


On Wed, 22 May 2013, Simon Horman wrote:

> include/linux/skbuff.h | 63 +++++++-------------------------------------------
> 1 file changed, 8 insertions(+), 55 deletions(-)
>
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index 2e0ced1..3791615 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -509,9 +509,9 @@ struct sk_buff {
> 		__u32		reserved_tailroom;
> 	};
>
> -	sk_buff_data_t		inner_transport_header;
> -	sk_buff_data_t		inner_network_header;
> -	sk_buff_data_t		inner_mac_header;
> +	__u16			inner_transport_header;
> +	__u16			inner_network_header;
> +	__u16			inner_mac_header;
> 	sk_buff_data_t		transport_header;
> 	sk_buff_data_t		network_header;
> 	sk_buff_data_t		mac_header;
>
Why not take one more step and use 16-bit fields for the other header 
fields too: transport_header, network_header and mac_header?

 	Pekka



More information about the dev mailing list