[ovs-dev] [PATCH v3 3/4] ovs-ctl.in: Restore flows with vswitchd packet processing disabled.

[Gurucharan Shetty]

On Thu, May 30, 2013 at 1:47 PM, Ben Pfaff <blp at nicira.com> wrote:

> On Thu, May 30, 2013 at 09:19:37AM +0000, Gurucharan Shetty wrote:
> > It has been observed that when we upgrade openvswitch with
> > thousands of openflow flows already established and there is heavy
> > traffic going through the switch, restoring flows can take a very
> > long time (8 minutes in one use case) with CPU running at 100%.
> > This can make the upgrade very expensive.
> >
> > This commit starts vswitchd by asking it to wait till flow restore is
> > finished. Once the flows are restored, it resumes normal operations.
> >
> > Bug #16086.
> > Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
>
> This looks correct to me.
>
> Each of flow_restore_wait()'s callers calls it with a literal string
> parameter.  It might be better to break it out into two functions, one
> equivalent to "flow_restore_wait true" and the other equivalent to
> "flow_restore_wait false", each with a clear name.
>
Okay. I will change this to flow_restore_wait (equivalent to
 "flow_restore_wait true")
and flow_restore_complete (equivalent to  "flow_restore_wait false")



>
> Thanks,
>
> Ben.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20130530/6ce8cd58/attachment-0003.html>