[ovs-dev] [PATCHv2 1/2] ofp-actions: Switch away from odd use of "q" in "enqueue" action format.

Ben Pfaff blp at nicira.com
Wed Nov 6 21:41:32 UTC 2013


On Wed, Nov 06, 2013 at 01:35:06PM -0800, Alex Wang wrote:
> On Sat, Nov 2, 2013 at 9:51 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > The formatting of the "enqueue" action uses a "q" to separate the port
> > number from the queue number, as in "enqueue:123q456".  This is different
> > from every other action.  This commit improves the situation by:
> >
> >     * Switching the formatting to use a colon (e.g. "enqueue:123:456"),
> >       which is a little less odd-looking but still accepted by older
> >       versions of Open vSwitch.
> >
> >     * Improving the parser to accept "enqueue(123,456)" also.
> 
> In the "str_to_ofpacts__()", we parse "," as a delimiter to separate
> actions.  So, we should not use ",".

str_to_ofpacts__() uses ofputil_parse_key_value(), which properly
handles commas within parentheses.  Other actions use such a syntax too.



More information about the dev mailing list