[ovs-dev] [PATCH v2] ofproto: Check ofproto_port_query_by_name() return value when adding port.

[Ben Pfaff]

On Thu, Nov 07, 2013 at 09:53:33AM -0800, Guolin Yang wrote:
> One question: If add successful but query fails, are there any cleanup need
> to be done here
> or it will be done in later loop?
> 
> Especially if query is temporary failure will the current code lead to
> irrecoverable state for
> the port?

It's a fair question, but, looking at the callers, I don't see any
obvious bugs in their error handling.  In general Open vSwitch
configuration is meant to be resilient against changes.  The goal is to
be able to transition from any existing state to any state requested by
the database configuration.  OVS is pretty good about actually
achieving that goal; I think that any exceptions must be very rare
corner cases at this point.

I'll apply this soon, thanks for looking at it.