[ovs-dev] [PATCH v2 0/8] Implement OFPMP_TABLE_FEATURES GET

Alexander Wu alexander.wu at huawei.com
Tue Nov 12 03:03:45 UTC 2013


Hi Ben,

On 12/11/2013 07:55, Ben Pfaff wrote:
>
> Thanks.
>
> These patches seem to be whitespace damaged.  Perhaps you could make
> them available through a branch somewhere?
>
>

Sorry for the whitespace. It's caused by direct copy of PDF file.
I've sent a correct version after the patches. You can find this one
in emails:
   [PATCH v2 0/8] Implement OFPMP_TABLE_FEATURES GET - Fix fi error

And you'll see the content below:

  Alexander Wu:

   This patch is to implement table features GET msg in openflow 1.3.

   The spec says:
    If the request body contains an array of one or more ofp_table_features
    structs, the switch will attempt to change its flow tables to match the
    requested flow table configuration. This operation configures the entire
    pipeline, and the set of flow tables in the pipeline must match the set
    in the request, or an error must be returned.

   It means OFPMP_TABLE_FEATURES consists of 2 parts: GET and SET.
   We implement the GET message now, and part of SET.
   But the entire SET message seems difficult, because it configures the
   whole pipeline.

   Currently we test the implement via NOX-OF1.3 and testsuite of ovs.
   But some implement (such as the cli) is crude, hope your suggestions.

   lib/ofp-msgs.h             |    4 +-
   lib/ofp-print.c            |  127 ++++++++-
   lib/ofp-util.c             |  723 ++++++++++++++++++++++++++++++++++++++++++++
   lib/ofp-util.h             |  153 ++++++++++
   lib/rconn.c                |    4 +-
   ofproto/ofproto-provider.h |    3 +
   ofproto/ofproto.c          |  388 +++++++++++++++++++++++-
   tests/ofp-print.at         |  187 ++++++++++++
   tests/ofproto.at           |   25 ++
   utilities/ovs-ofctl.c      |   17 +
   10 files changed, 1625 insertions(+), 6 deletions(-)

-- 
Best Regards,
Alexander Wu




More information about the dev mailing list