[ovs-dev] [PATCH 0/4] replace sscanf() by our own implementation

Jarno Rajahalme jrajahalme at nicira.com
Fri Nov 15 18:20:25 UTC 2013


On Nov 15, 2013, at 9:47 AM, Ben Pfaff <blp at nicira.com> wrote:

> On Sat, Nov 09, 2013 at 03:55:03PM -0800, Ben Pfaff wrote:
>> The Windows implementation of sscanf() is defective: it does not support
>> the 'hh' modifier.  There is an effort on to port OVS to Hyper-V, so this
>> is a problem.  This series adds an implementation of sscanf() to the tree,
>> under the name ovs_scan(), which allows for some improvements elsewhere
>> as a consequence.
> 
> I accidentally pushed all of these patches to master while intending to
> push only one other patch.  Sorry about that.  However, I think it's OK:
> the big patch in the series had already been tested and reviewed, and
> the rest are pretty trivial.
> 
> Please feel free to review them anyway, if you like, and I'll definitely
> fix any problems spotted.
> 

clang complains:

lib/util.c:1500:34: warning: comparison of constant 18446744073709551615 with
      expression of type 'const unsigned int' is always false
      [-Wtautological-constant-out-of-range-compare]
    unsigned int n = spec->width == SIZE_MAX ? 1 : spec->width;
                     ~~~~~~~~~~~ ^  ~~~~~~~~

And:

 37: ovs_scan() function                             FAILED (library.at:112)

testsuite.log:

+test-util: tests/test-util.c:908: assertion ovs_scan(" Hello,\tworld ", "%*c%n%*c%n%c%n", &n, &n2, &c, &n3) failed in test_ovs_scan()

I’m compiling 64-bit, btw.

   Jarno




More information about the dev mailing list