[ovs-dev] [PATCH v2 1/2] ofproto: Add table config to struct ofproto

Ben Pfaff blp at nicira.com
Thu Nov 21 00:59:19 UTC 2013


On Wed, Nov 13, 2013 at 01:25:22PM +0900, Simon Horman wrote:
> Add table config to to struct ofproto and set it
> when a table mod message is received.
> 
> This is in preparation for changing the behaviour of the switch
> based on table config.
> 
> Cc: Andy Zhou <azhou at nicira.com>
> Signed-off-by: Simon Horman <horms at verge.net.au>

The 'config' member seems like a perfect place to use an atomic.  A
rwlock is overkill.

I don't see anything in handle_table_mod() that validates that the
table_id is in the supported range.

Thanks,

Ben.



More information about the dev mailing list