[ovs-dev] [PATCH] Update subfacet stats for slow path flow

gyang at nicira.com gyang at nicira.com
Thu Nov 21 18:21:28 UTC 2013


From: Guolin Yang <gyang at nicira.com>

The slow path stats are not updated which cause slow path flow to be
deleted periodically. This patch update the slow path flow as fast
path flow so that the flow will not be aged out.

Another option is update the subfacet for slow path when packet is received
and that is original code but it is removed.

One note is with this change, one of ofproto-dpif test fail, probably should
update the test case also.

Signed-off-by: Guolin Yang <gyang at nicira.com>
---
 ofproto/ofproto-dpif.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index c1c206b..51ed0b7 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
@@ -3592,11 +3592,8 @@ update_stats(struct dpif_backer *backer)
         subfacet = subfacet_find(backer, key, key_len, key_hash);
         switch (subfacet ? subfacet->path : SF_NOT_INSTALLED) {
         case SF_FAST_PATH:
-            update_subfacet_stats(subfacet, stats);
-            break;
-
         case SF_SLOW_PATH:
-            /* Stats are updated per-packet. */
+            update_subfacet_stats(subfacet, stats);
             break;
 
         case SF_NOT_INSTALLED:
-- 
1.7.9.5




More information about the dev mailing list