[ovs-dev] [PATCH 7/9] rconn: Allow OFPMP_TABLE_FEATURES openflow messages.

Ben Pfaff blp at nicira.com
Thu Nov 21 22:35:28 UTC 2013


On Thu, Nov 21, 2013 at 05:04:34PM +0800, Alexander Wu wrote:
> V3:
>   No change.
> 
> V2:
>   No change.
> 
> V1:
>   Make the enums allowed
> 
> Signed-off-by: Alexander Wu <alexander.wu at huawei.com>
> Reviewed-by: Simon Horman <horms at verge.net.au>

This misjudges the purpose of this function.  It does not deliver an
"allow" or "drop" verdict.  Instead, it gives the caller its best
guess whether a particular message means that the controller has
decided to accept this OpenFlow connection.

I see that this function could be improved in a few ways.  I'll send
out a patch to do that.  But I believe that this patch should be
dropped.



More information about the dev mailing list