[ovs-dev] [PATCH 3/9] ofproto-provider: Add/Modify headers for OFPMP_TABLE_FEATURES in ofproto

[Ben Pfaff]

On Mon, Nov 25, 2013 at 02:16:23PM +0800, Alexander Wu wrote:
> On 22/11/2013 06:21, Ben Pfaff wrote:
> >On Thu, Nov 21, 2013 at 05:04:30PM +0800, Alexander Wu wrote:
> >>V3:
> >>   Add description for table-features get/set struct.
> >>
> >>V2:
> >>   No change.
> >>
> >>V1:
> >>   Add table_feature structs in ofproto && oftable to initialize.
> >>   The struct in ofproto is used to get
> >>   The struct in oftable is used to set (set is not implement yet)
> >>
> >>Signed-off-by: Alexander Wu <alexander.wu at huawei.com>
> >
> >I would put both new members in struct oftable.
> >
> >
> 
> It's a optimization of TABLE_FEATURES get request.
> A get request always read ofproto->otf, it's a long memory, and put
> it in ofproto makes it compact, or cpu would run slower on this case.
> Sure that it's a little odd at first sight.

It doesn't matter how fast the table_features get request runs.  A
controller is going to use that request once per OpenFlow session, if
it uses it at all.