[ovs-dev] [fd leak v2 3/3] dpif-linux: Fix fd leak for vports that disappear from the datapath.

Alex Wang alexw at nicira.com
Mon Nov 25 20:49:45 UTC 2013


LGTM, only one thing,

I did the following test:

"""
root at server329:~/ben-reviews# ovs-vsctl --version
ovs-vsctl (Open vSwitch) 2.0.90
Compiled Nov 25 2013 11:44:29
root at server329:~/ben-reviews# lsof -p `pidof ovs-vswitchd` | wc -l

31
*root at server329:~/ben-reviews# ovs-vsctl add-br test*
root at server329:~/ben-reviews# lsof -p `pidof ovs-vswitchd` | wc -l
44
*root at server329:~/ben-reviews# ip link add name foo type veth peer name bar*
root at server329:~/ben-reviews# lsof -p `pidof ovs-vswitchd` | wc -l

44
*root at server329:~/ben-reviews# ovs-vsctl add-port test foo*
root at server329:~/ben-reviews# lsof -p `pidof ovs-vswitchd` | wc -l
45
*root at server329:~/ben-reviews# ip link delete foo*
root at server329:~/ben-reviews# lsof -p `pidof ovs-vswitchd` | wc -l
43
*root at server329:~/ben-reviews# **ovs-vsctl del-port foo*
root at server329:~/ben-reviews# lsof -p `pidof ovs-vswitchd` | wc -l
43
root at server329:~/ben-reviews#
"""


After adding the veth, the fd count is incremented by 1.  But after
deleting it, the fd count is decremented by 2.  So, seem to me that there
is other place that can delete the vport but not the channel.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20131125/717ffde4/attachment-0003.html>


More information about the dev mailing list