[ovs-dev] [PATCH] ofproto-dpif: Correct endian problem in recv_upcalls()

Ben Pfaff blp at nicira.com
Tue Oct 1 15:21:24 UTC 2013


On Tue, Oct 01, 2013 at 03:15:22PM +0900, Simon Horman wrote:
> Use nl_attr_get_u32() instead of nl_attr_get_be32() to parse nla
> so that the decoded value which is passed to mhash_add()
> is host byte order as mhash_add() expects.
> 
> This resolves a minor regression introduced by
> 10e576406c7444ef ("ofproto-dpif: Move special upcall handling into
> ofproto-dpif-upcall.").
> 
> I do not expect this change has any runtime implications.
> 
> Detected using sparse.
> 
> Cc: Ethan Jackson <ethan at nicira.com>
> Cc: Ben Pfaff <blp at nicira.com>
> Signed-off-by: Simon Horman <horms at verge.net.au>

Applied, thank you!



More information about the dev mailing list