[ovs-dev] [PATCH v2 2/2] TCP flags matching support.

[Jesse Gross]

On Wed, Sep 25, 2013 at 9:42 AM, Jarno Rajahalme <jrajahalme at nicira.com> wrote:
> diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
> index 09c26b5..2642ca5 100644
> --- a/include/linux/openvswitch.h
> +++ b/include/linux/openvswitch.h
> @@ -291,6 +291,8 @@ enum ovs_key_attr {
>         OVS_KEY_ATTR_MPLS = 62, /* array of struct ovs_key_mpls.
>                                  * The implementation may restrict
>                                  * the accepted length of the array. */
> +       OVS_KEY_ATTR_TCP_FLAGS, /* be16 TCP flags. */

I would put this after SCTP and not use a temporary value. The MPLS
patch should hopefully land soon but since there's no kernel code
currently checked-in for that, there's no interface breakage when
moving things around. We can just allocate IDs based on the order that
the patches are applied.

Otherwise this looks OK to me.