[ovs-dev] [PATCH 3/8] nsh: support for setting nsp, action set_nsp=<value>

Jarno Rajahalme jrajahalme at nicira.com
Tue Oct 1 21:49:04 UTC 2013


On Sep 20, 2013, at 1:04 AM, pritesh <pritesh.kothari at cisco.com> wrote:

> Support for setting nsp using an action namely set_nsp. It works similar to
> set_tunnel in vxlan/gre tunnel and can be used to set the outgoing nsh
> service path id.

Should tell here that NXM_NX_NSP is also defined, which enables
matching NSPs.

A new action is not needed to set the NSP. You can make NSP writeable
(see below), and use the existing load and move actions to set it. Also, in
OF 1.2+ you can use the standard set field action to set it as well.

> 
> Signed-off-by: pritesh <pritesh.kothari at cisco.com>
> 
...
> diff --git a/lib/meta-flow.c b/lib/meta-flow.c
> index 1d175d5..67ddd3e 100644
> --- a/lib/meta-flow.c
> +++ b/lib/meta-flow.c
> @@ -707,7 +707,7 @@ static const struct mf_field mf_fields[MFF_N_IDS] = {
>         MFS_HEXADECIMAL,
>         MFP_NONE,
>         false,

If you made this "true" the "set_field", "load" and "move" actions could also
be used to set the NSP. Then the new action is not necessary at all.

> -        0, NULL,
> +        NXM_NX_NSP, "NXM_NX_NSP",
>         0, NULL,
>         OFPUTIL_P_OF10_NXM_ANY,
>         OFPUTIL_P_OF10_NXM_ANY,

The last two lines should be set to:

        OFPUTIL_P_NXM_OXM_ANY,
        OFPUTIL_P_NXM_OXM_ANY,

to signify that any protocol version that can encode NXM  or OXM can use this field.






More information about the dev mailing list