[ovs-dev] [PATCH 1/5] ofproto-dpif: Move send_packet() to ofproto-dpif-xlate module.

Ben Pfaff blp at nicira.com
Tue Oct 1 22:37:22 UTC 2013


On Tue, Oct 01, 2013 at 01:36:11PM -0700, Alex Wang wrote:
> This commit moves the main logic of send_packet() function into
> the ofproto-dpif-xlate module.  Also, modification is made to
> guarantee the thread safety of ofproto-dpif-xlate module.
> 
> Signed-off-by: Alex Wang <alexw at nicira.com>

xlate_send_packet() locks xlate_rwlock before it looks up the xport,
but at the end it unlocks xlate_rwlock before it dereferences
xport->xbridge->dpif.  Is the latter dereference safe, that is, does
anything guarantee that 'xport' and 'xbridge' aren't destroyed?

In ofproto/ofproto-dpif-xlate.h, we usually put a blank line before
the #endif.

Thanks,

Ben.



More information about the dev mailing list