[ovs-dev] [PATCH 7/8] nsh: support for setting nsh contexts

[Pritesh Kothari (pritkoth)]

On Oct 1, 2013, at 3:13 PM, Jarno Rajahalme wrote:

> 
> On Sep 20, 2013, at 1:04 AM, pritesh <pritesh.kothari at cisco.com> wrote:
> 
>> Support for setting the nsh network and service contexts is added here.
>> The support is added only for adding context while the port is created.
> 
> I understand that this may be an intermediate step, but how are these
> useful as part of the tunnel port configuration?

actually after putting a lot of thought a few days ago, i am in process of removing them (more details below)

> 
>> Support for carrying forward context from incoming packet to the
>> outgoing packet is not supported yet.
>> 
>> Signed-off-by: pritesh <pritesh.kothari at cisco.com>
>> 
>> 
> ...
>> diff --git a/lib/netdev.h b/lib/netdev.h
>> index c23fe25..0b69841 100644
>> --- a/lib/netdev.h
>> +++ b/lib/netdev.h
>> @@ -142,6 +142,11 @@ struct netdev_tunnel_config {
>>    bool csum;
>>    bool ipsec;
>>    bool dont_fragment;
>> +
>> +    ovs_be32 nsh_npc;           /* NSH network platform context */
>> +    ovs_be32 nsh_nsc;           /* NSH network shared context */
>> +    ovs_be32 nsh_spc;           /* NSH service platform context */
>> +    ovs_be32 nsh_ssc;           /* NSH service shared context */
> 
> 
> Again, do you think that these make sense as part of tunnel configuration,
> or should these be supported on flow-level only? In other words, do you
> envision configuring a separate tunnel port for each different combination
> of all the key,nap,nsi,npc,nsc,spc,sec combination any service may want to
> use?

actually there are few use cases which take this into consideration, but on second thought
could very well be handled by setting flow entries alone and thus this patch is actually 
more confusing. the plan ahead here would be to support these parameters at flow level?

Regards,
Pritesh

> Or would the controller rather set flow entries to match the "service
> flows"?
> 
>  Jarno
>